On Fri, 21 Aug 2026 16:49:48 GMT, Chris Plummer <[email protected]> wrote:
>>> > How do these changes relate to the following bug? >>> > [JDK-8247507](https://bugs.openjdk.org/browse/JDK-8247507) SA: >>> > MetadataField.java needs to support inlined fields >>> >>> This PR does not match exactly with JDK-8247507, but has same approach with >>> it. >>> >>> JDK-8247507 focuses on metadata, but this PR focuses on oop traversal (not >>> metadata). It is same way that It gets metadata (`Klass`) from holder class >>> when the oop is `InlineKlass`. AFAICS fetching flattened object (oop) by >>> `inspect` CLHSDB command does not need to access `MetadataField` because we >>> just want the value only. So I didn't modify `MetadataField` in this PR. >> >> Ok. I'm just wondering where SA functionality is not working due to >> JDK-8247507. > >> > > How do these changes relate to the following bug? >> > > [JDK-8247507](https://bugs.openjdk.org/browse/JDK-8247507) SA: >> > > MetadataField.java needs to support inlined fields >> > >> > >> > This PR does not match exactly with JDK-8247507, but has same approach >> > with it. >> > JDK-8247507 focuses on metadata, but this PR focuses on oop traversal (not >> > metadata). It is same way that It gets metadata (`Klass`) from holder >> > class when the oop is `InlineKlass`. AFAICS fetching flattened object >> > (oop) by `inspect` CLHSDB command does not need to access `MetadataField` >> > because we just want the value only. So I didn't modify `MetadataField` in >> > this PR. >> >> Ok. I'm just wondering where SA functionality is not working due to >> JDK-8247507. > > Should we close JDK-8247507 as "not an issue"? @plummercj I pushed new commit to fix your comment. It is not small, so please check the commit directly if you want to check the diff: https://github.com/openjdk/jdk/pull/32310/changes/ae766f2a5271189719c9be761c36691f27c2eaf6 ------------- PR Comment: https://git.openjdk.org/jdk/pull/32310#issuecomment-5450803371
