On Mon, 19 Oct 2026 14:17:25 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Patrick Fontanilla has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused forward declaration
>
> src/hotspot/share/memory/heapInspection.cpp line 727:
>
>> 725: if (active_workers <= 1) {
>> 726: workers = nullptr;
>> 727: }
>
> Suggestion:
>
> // Use parallel workers if we have enough active workers and parallel heap
> iteration is supported.
> WorkerThreads* workers = nullptr;
> if (Universe::heap()->supports_parallel_object_iteration() && num_workers >
> 1) {
> const uint active_workers =
> DiagnosticWorkers::try_and_set_active_workers(num_workers);
> if (active_workers > 1) {
> workers = DiagnosticWorkers::workers();
> }
> }
I'll apply this suggested change, but I'll need to change
`try_and_set_active_workers()` for this to work since it relies on the pool
being created beforehand.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33218#discussion_r4316656404
