On Mon, 19 Oct 2026 14:19:22 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Patrick Fontanilla has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unused forward declaration > > src/hotspot/share/nmt/memMapPrinter.cpp line 232: > >> 230: } >> 231: >> 232: ThreadStackClosure diag_cl(from, to); > > Not sure why it is under `Universe::heap()` check here. The old code > understandably does that since it performs later access to > `Universe::heap()`. Sure, this works now since it serves as "bootstrap is > completed" check. But maybe we can just do > `DiagnosticWorkers::diagnostic_threads_do` without prior check, and will > still be fine? Ok, I'll move it outside the check. Should be harmless. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33218#discussion_r4316467749
