On Mon, 19 Oct 2026 14:14:00 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Patrick Fontanilla has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused forward declaration
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp line 291:
>
>> 289: PLAB* gclab = ShenandoahThreadLocalData::gclab(thread);
>> 290: if (gclab == nullptr) {
>> 291: assert(!thread->is_Java_thread() && !is_gc_worker_thread(thread),
>
> So all this `is_gc_worker_thread` scaffolding is only to satisfy this
> particular assert, right? This walks all worker threads every time we ask.
> And we ask quite a bit from diagnostic workers, since they do not have PLABs.
>
> I think we can remove this assert here completely, and instead do the
> GCLAB/PLAB existence verification in verifier. There, we could also check
> that no _other_ threads _have_ a GCLAB/PLAB. This can be done in a separate
> RFE.
Yes, that would simplify a lot of things with this PR. I'll file the RFE later
today.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33218#discussion_r4316516892
