On Mon, 19 Oct 2026 14:20:18 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Patrick Fontanilla has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unused forward declaration > > src/hotspot/share/services/diagnosticWorkers.cpp line 43: > >> 41: // Use release_store() because the error reporter can read _workers >> while >> 42: // the pool is being created. >> 43: _workers.release_store(pool); > > Yeah, but concurrent calls to this method would leak one instance of > `WorkerThreads`. You need to CAS the instance and free the instance that lost > the installation race. Does it really need CAS? Creating the pool is always done by the VM thread, so it should be thread safe, right? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33218#discussion_r4317729489
