On Tue, 20 Oct 2026 21:09:46 GMT, Vladimir Kozlov <[email protected]> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @vnkozlov comment -- removed unnecessary code
>
> src/hotspot/share/cds/aotHeap.cpp line 1950:
>
>> 1948: } else if (java_lang_Class::is_instance(orig_obj) && subgraph_info
>> == _dump_time_special_subgraph) {
>> 1949: orig_obj = scratch_java_mirror(orig_obj);
>> 1950: assert(orig_obj != nullptr, "must be archived");
>
> Please add comment explaining why you need this check and code.
This change is unnecessary and I removed it. Actually, I added it because the
surrounding code is confusing. I will try to clean this up in a separate RFE.
> src/hotspot/share/cds/cdsConfig.cpp line 801:
>
>> 799: // Re-training
>> 800: FLAG_SET_ERGO_IF_DEFAULT(AOTReplayTraining, true);
>> 801: AOTCodeCache::enable_caching();
>
> AOTCodeCache::enable_caching() should depend on AOTReplayTraining which could
> be switched off on command line.
`FLAG_SET_ERGO_IF_DEFAULT` will set the flag only if it's not specified in the
command-line. The old code also did the same thing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31344#discussion_r4332881218
PR Review Comment: https://git.openjdk.org/jdk/pull/31344#discussion_r4332885664
