Re: RFR: 8353598: Iterative AOT Training Run [v3]

[Ioi Lam]

On Wed, 21 Oct 2026 16:42:01 GMT, Vladimir Kozlov <k...@openjdk.org> wrote:

>> I commented about unconditionally enabling AOT code caching in your changes. 
>> In previous code we had:
>> 
>>     FLAG_SET_ERGO_IF_DEFAULT(AOTReplayTraining, true);
>>     // Generate AOT code only when training data enabled
>>     if (AOTReplayTraining) {
>>       AOTCodeCache::enable_caching();
>>     } else {
>>       AOTCodeCache::disable_caching();
>>     }
>
> Or may be add `AOTReplayTraining` check inside 
> `AOTCodeCache::enable_caching()`

Thanks for the explanation. I restored the code to do the same as before:


FLAG_SET_ERGO_IF_DEFAULT(AOTReplayTraining, true);
if (AOTReplayTraining) {
  AOTCodeCache::enable_caching();

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31344#discussion_r4344211406