On Wed, 21 Oct 2026 16:38:59 GMT, Vladimir Kozlov <[email protected]> wrote:
>> `FLAG_SET_ERGO_IF_DEFAULT` will set the flag only if it's not specified in
>> the command-line. The old code also did the same thing.
>
> I commented about unconditionally enabling AOT code caching in your changes.
> In previous code we had:
>
> FLAG_SET_ERGO_IF_DEFAULT(AOTReplayTraining, true);
> // Generate AOT code only when training data enabled
> if (AOTReplayTraining) {
> AOTCodeCache::enable_caching();
> } else {
> AOTCodeCache::disable_caching();
> }
Or may be add `AOTReplayTraining` check inside `AOTCodeCache::enable_caching()`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31344#discussion_r4339409608
