On 8/18/17 8:37 , Daniel Kontsek wrote: > Thank you very much Cody for pointing me in the right direction. > > I already went ahead and followed the Gerrit instructions and created a CR: > https://cr.joyent.us/#/c/2353/ <https://cr.joyent.us/#/c/2353/> I did this to > learn the process of working with Gerrit (not that the bug/CR itself isn’t > important - it is). The workflow is different compared to the GitHub/GitLab > (forks/branches) style. I’ve accidentally created and abandoned another CR > when pushing an update to gerrit - sorry for that. Then I followed the Gerrit > documentation to update the CR and I’ve just noticed the "We have one major > exception to the standard Gerrit workflow:…” message in the wiki. I’ve used > the “amend + Change-Id” method to add another patchset and again: I’m sorry > for that (I didn’t notice it the first time). > > Should I abandon the Change 2353 and create a new one?
Hi Daniel, There should be no need. It's fine. The only reason we're not using the Change-Id method is because of the final commit message. Even if it's used in the interim it shouldn't cause any problems. Thanks, Robert ------------------------------------------- smartos-discuss Archives: https://www.listbox.com/member/archive/184463/=now RSS Feed: https://www.listbox.com/member/archive/rss/184463/25769125-55cfbc00 Modify Your Subscription: https://www.listbox.com/member/?member_id=25769125&id_secret=25769125-7688e9fb Powered by Listbox: http://www.listbox.com
