Antonello Cruz writes:
> Please find the webrev at
>
> http://cr.opensolaris.org/~acruz/6855845/
>
> Ideally we would like to integrate by next Monday 07/06/2009 when build
> 119 closes. Feedback in time to integrate in build 119 would be highly
> appreciated.
>
> Thanks,
>
> Antonello
> _______________________________________________
> smf-discuss mailing list
> smf-discuss at opensolaris.org
Good job. Just a few quick comments.
usr/src/cmd/svc/svccfg/svccfg_xml.c:
line 2848: Watch out for xmlGetProp(). Sometimes it returns
an empty string rather than a NULL pointer when an
element is not set in the manifest. I don't recall
exactly the circumstances when this happens. It
looks to me as if you code correclty handles this
situation, so I'm not asking you to change
anything. I just wanted you to be aware of this
xmlGetProp() behavior.
usr/src/cmd/svc/svccfg/svccfg_libscf.c:
line 2181: If we're importing service PGs, shouldn't
sc_service be true?
tom
