Sean Wilcox wrote: > svccfg_libscf.c > nit - should there be a blank line after 2197 Good catch! I would be nice if cstyle could point this out...
> nit - 7520/7521 should be a block comment. Done, ditto! > 7350 instnace should be instance me and my fat fingers... fixed! > > For the _lscf_refresh_all_isntances() would it be better to use the > refresh_entity() which does the same thing if isservice is set. I considered refresh_entity() but since it uses global state from engine_state_t *est I thought it would be better not to use it. Did you consider the possible side-effects from different possible states in est? Thanks for the feedback, Antonello > > Antonello Cruz wrote: >> Please find the webrev at >> >> http://cr.opensolaris.org/~acruz/6855845/ >> >> Ideally we would like to integrate by next Monday 07/06/2009 when >> build 119 closes. Feedback in time to integrate in build 119 would be >> highly appreciated. >> >> Thanks, >> >> Antonello >> _______________________________________________ >> smf-discuss mailing list >> smf-discuss at opensolaris.org >> >> >
