Tony Nguyen wrote: > Looking good. Just some nits. > > svccfg_engine.c > > engine_apply(const char *file, int apply_changes) - it's common to > interpret 1 as true or apply in this case. Not a big deal though. Make sense, I changed it.
> > svccfg_libscf.c > > _lscf_refresh_all_instances() - it'd be simpler to initialize r to -1 > and avoid all the assignments and set it to 0 if we get to the end of > the function. Also makes sense... also changed it :-) Thanks, Antonello