Antonello Cruz wrote: > Please find the webrev at > > http://cr.opensolaris.org/~acruz/6855845/ > > Ideally we would like to integrate by next Monday 07/06/2009 when > build 119 closes. Feedback in time to integrate in build 119 would be > highly appreciated. > Looking good. Just some nits.
svccfg_engine.c engine_apply(const char *file, int apply_changes) - it's common to interpret 1 as true or apply in this case. Not a big deal though. svccfg_libscf.c _lscf_refresh_all_instances() - it'd be simpler to initialize r to -1 and avoid all the assignments and set it to 0 if we get to the end of the function. -tony
