I replied yesterday but if you want another confirmation. The changes are good me :)
-tony Antonello Cruz wrote: > I have talked with Sean offline and he pointed the global state in > svccfg_libscf.c:refresh_entity() is used to keep track of alternate > repositories. It make sense to use the infrastructure that already > exists instead of re-creating similar functionality. Thanks Sean! > > Incremental webrev - just the use of refresh_entity() update > http://cr.opensolaris.org/~acruz/6855845-diff-2-3/ > > Full webref > http://cr.opensolaris.org/~acruz/6855845-3/ > > Incremental from the firs webrev at > http://cr.opensolaris.org/~acruz/6855845/ > http://cr.opensolaris.org/~acruz/6855845-diff-3/ > > Please Tony, send me feedback if you're ok with the changes I made > regarding your comments. > Same to you Sean. > Tom, feel free to take another look at the last changes. > > Thank you all for the valuable feedback. > > Antonello > > Antonello Cruz wrote: >> Thanks Tom, Sean and Tony for the feedback! >> >> Please find new webrevs below: >> >> Incremental webrev: >> http://cr.opensolaris.org/~acruz/6855845-diff/ >> >> Full webrev: >> http://cr.opensolaris.org/~acruz/6855845-2/ >> >> I also included the very simple fix for >> '6855772 svccfg dumps core during installation' >> which is just the break; statement in svccfg_libscf.c:2146 >> Although the fix is simple, the analysis was not. Thanks Sean for the >> thorough analysis on this bug! >> >> Thanks again, >> >> Antonello >> >> >> Antonello Cruz wrote: >>> Please find the webrev at >>> >>> http://cr.opensolaris.org/~acruz/6855845/ >>> >>> Ideally we would like to integrate by next Monday 07/06/2009 when >>> build 119 closes. Feedback in time to integrate in build 119 would be >>> highly appreciated. >>> >>> Thanks, >>> >>> Antonello >>> _______________________________________________ >>> smf-discuss mailing list >>> smf-discuss at opensolaris.org >> _______________________________________________ >> smf-discuss mailing list >> smf-discuss at opensolaris.org > _______________________________________________ > smf-discuss mailing list > smf-discuss at opensolaris.org
