On Donnerstag 07 September 2006 23:33, Marko Mäkelä wrote: > On Thu, Sep 07, 2006 at 06:55:36AM +0200, Stefan Lucke wrote: > > Could you check your logs to see if there is an even/odd combination > > of source and destination yoffset ? > > When viewing that BBC News clip at CropMode 14:9, it shows > > src (44,0 632x576) > dst (0,41 720x494) > > when I enabled the fprintf calls in cDFBVideoOut::YUV(). > > All other CropModes look fine, and both the source and destination yoffsets > are even in all of them. > > So, I think that your guess is correct. Truncating the destination > yoffset to an even number seems to do the trick on the three 16:9 clips > I tested: > > diff -p -u -r1.62 video.c > --- video.c 4 Sep 2006 20:29:54 -0000 1.62 > +++ video.c 7 Sep 2006 21:30:39 -0000 > @@ -266,7 +266,7 @@ void cVideoOut::AdjustToDisplayGeometry( > * center result on display > */ > lxoff = (dwidth - lwidth) / 2; > - lyoff = (dheight - lheight) / 2; > + lyoff = ((dheight - lheight) / 2) & ~1; > } > > /* > --------------------------------------------------------------------------- > > Please document the reason for this in the source code, and consider making > it conditional (only on mgatv output).
It should be done allways, even for lxoff because in YV12 luma is used for 2 horizontal and 2 vertical pixels. Maybe this is causing troubles for other cards like nVidia too ! > > By the way, what is the 14:9 crop mode good for? For viewing 3:2 > photographs? We only seem to get 4:3 and 16:9 programs. > -- Stefan Lucke _______________________________________________ Softdevice-devel mailing list [email protected] https://lists.berlios.de/mailman/listinfo/softdevice-devel
