On Wednesday 26 November 2008 04:29:25 am Miroslav Suchý wrote: > Dennis Gilmore wrote: > > I think we can assume if its not tagged that means that the work is not > > complete and not ready to be built or tested. > > I spoke about make tag-release, which make git tag. Do not mistake it > for koji tag. > > >> 2) Create tag dist-5E-sw-0.4. Normally build into > >> dist-5E-sw-0.4-candidate as now and unsuccessful builds tag into > >> dist-5E-sw-0.4. Final Spacewalk create from dist-5E-sw-0.4 tag. > >> For nightly builds, let call "make test-srpm" on untagged packages and > >> build in koji the packages with .git.longsha1 dist tag. > >> This way you make sure when somebody finally tag the package (which bump > >> up the version automatically) such package will be upgraded to last > >> version. I prefer this option. > > > > Im assuming that you mean moving successful builds into dist-5E-sw-0.4 > > No I meant koji tag-pkg dist-5E-sw-0.4 sucessfull-build > I really do not see benefit of moving in compare to tag it to final tag > as well (beside the -candidate one) tagging packages like that is the completely wrong thing to do. we should run koji move-tag dist-5E-sw-0.4-candidate dist-5E-sw-0.4 <successful build> you said unsuucessful build initially which is why i assumed successful build.
moving the package out of the candidate tag lets us know that its been though some level of checking. > > I do not thing we are that far away from teh same goals. I just think > > that doing builds needs to be the deliberate action of an engineer. We > > can and should make "make tag" do the build also. > > Are we still speaking about nightly builds? Now I only care about final > release that way that I do not want to break process of final release. > > Ok. So make the question straight: > Will I break something in your rel-eng realm, if I start building > testing packages (like > SatConfig-installer-3.24.4-1.git.a352eaab737b87fd46849a6e982c096aa99cc636.s >rc.rpm) in dist-5E-sw-0.4-candidate? If you do that it wont break anything but I really would prefer that you do not do that. packages built in candidate should be builds that could be considered for the final release. how about we set up a dist-5E-sw-0.4- snapshot tag? you can freely build whatever you want in it. since it will not be in consideration for the release. Dennis
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
