On Wed, Nov 26, 2008 at 8:23 AM, Jan Pazdziora <[EMAIL PROTECTED]> wrote: > On Wed, Nov 26, 2008 at 01:50:45PM +0100, Miroslav Suchý wrote: >> >> That is probably OK with small packages (like nocpulse-common), but it >> do not work with main packages (like java), which are usually rebuild >> only once just before the final release. Therefore nobody can test it. > > I assume guys working on spacewalk-java do not consider it stable > enough yet, that's why they did not tag it.
It's not that is it unstable, it is mostly because no one asked for them :) most of the folks working on spacewalk-java use the latest code from git and test it as we go along. Sure it doesn't test on an installed system, it just gets used on an on going basis. Another issue is we don't have a clear package owner, I've been the defacto owner but even then I don't consider myself 'THE OWNER' of the package, just the guy who builds it the most :) As far as auto building the rpm, I don't like that idea. I prefer that a developer build it manually. >>> Why do you want to build packages from state when they were not tagged >>> (= signed off by developer)? Just wait for the developer to make >>> tag(-minor)-release. >> >> That is for what people create nightly builds. >> You do not want it? Do not use it and wait for QA repo. >> You want test even partial work. Use it. >> And the code in git should work. If it do not work, why did you push it >> there in first place. > > Because you are allowed to do so. I'm not that perfect and sometimes > things do not work the first time I feel I'm finished. And I have to > fix stuff. Agreed. I understand that some projects to nightly builds, but usually it's a tar ball they are building, not a complete set of packages. I have no problem with us building a nightly repo based on built packages from that day. So if I want my changes to be in tonights nightly build, I need to push my changes, *AND* build the packages so they get pulled in by the nightly process. Otherwise, the nightly remains the same if no new packages were built. I don't see what a nightly pull from git will prove except a new bug or two. I certainly don't want to be chasing bugs down in a nightly repo when I didn't want my stuff out there yet. >> But again the main reason is stated in my first paragraph of this email. > > Ask developers of packages that don't seem to be tagged (often enough) > why they do not tag them. > > To summarize: from my point of view building test-srpm (the > .git.longsha1) packages to dist-5E-sw-0.4-candidate is > counterinuitive. It has that longsha1 in its name for a reason, to warn > everybody that it was built from some random commit, not signed off by > the developer (via make tag-release). If you start feeding them to > dist-5E-sw-0.4-candidate, before long they will make their way to > dist-5E-sw-0.4 and you will see things like > SatConfig-general-1.215.38-7.git.4c57d3b9f251dd5dc7113ecf37c30cecbb6d88c1.i386.rpm > in our yum repo. > > Other guys might have different opinion. +1 I don't like building the git.longsha1 in -candidate tag. To me if I want to build a git.sha1 I'll build it on my workstation so I can test it. If it works, then I can tag and build it, and let it go into the nightly for others to use. jesus _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
