On 2 February 2018 at 20:32, Jan Mulder <jlmul...@xs4all.nl> wrote:
> On 02-02-18 18:51, Dirk Hohndel wrote:
>> Hi there,
>> I’m finally back and feeling well. Still catching up with all the activity
>> on GitHub - it’s so nice to see that things continue even if I’m not
>> available.
>> Thanks to Jan, Robert, Lubomir, and everyone else who kept things moving!
> Good to have you back Dirk. As you can see on GitHub, I (and I think most of
> guys that can commit to master) sometimes struggle a little with the
> question "Should I commit this or just wait for Dirk?" And than Willem
> starts asking "do I need to do something to my PR to get it merged" :-) when
> a simple PR is sitting idle for a couple of days.

i usually approve a PR, but wait for approver to double check. if it's
something very simple i will merge right away, though.
the PR from Willem was just waiting for another review (label: needs-ack).

subsurface mailing list

Reply via email to