Sun, 31 Jul 2011 22:28:36 +0200, /Jens Hatlak/:
> Stanimir Stamenkov wrote:
>
>> 1. Secure Login <https://addons.mozilla.org/addon/secure-login/>
>>
>> It is not packaged as SeaMonkey compatible but is easily patched
>> to make it so - see "secure_login+sm.diff" attached.
>
> That's a good start, but there are some more issues hidden under the
> hood. For example, the automatic submitting doesn't seem to work
> with SM (i.e. needs further fixes). One issue I've found is in
> secureLogin.js, function initializeSignonAutofillFormsStatus.
> There's a version check that doesn't take the application into
> account. The author's intention was to check for FF 2.x, but SM 2.x
> also runs into that code.
Attaching an updated patch which should supposedly address all
SeaMonkey compatibility points. This one addresses the addition of
"Secure Login" menu entry in the Tools menu per:
https://developer.mozilla.org/en/Extensions_support_in_SeaMonkey_2#Differences_as_compared_to_other_toolkit.2f-based_applications
Still, I don't know why the menu entry appears between "Clear
Private Data" and "Data Manager", and not before "Password Manager"
(after "Data Manager") as instructed in "secureLoginOverlay.xul":
<menupopup id="taskPopup">
<menu id="secureLoginToolsMenu" insertbefore="menu_passwordManager"/>
</menupopup>
--
Stanimir
diff -r 87508a3527d0 chrome.manifest
--- a/chrome.manifest Sat Aug 06 18:58:22 2011 +0300
+++ b/chrome.manifest Sat Aug 06 19:25:52 2011 +0300
@@ -19,6 +19,7 @@
locale securelogin zh-TW chrome/locale/zh-TW/
skin securelogin classic/1.0 chrome/skin/
overlay chrome://browser/content/browser.xul
chrome://securelogin/content/secureLoginOverlay.xul
+overlay chrome://navigator/content/navigator.xul
chrome://securelogin/content/secureLoginOverlay.xul
style chrome://global/content/customizeToolbar.xul
chrome://securelogin/skin/secureLogin.css
style chrome://browser/content/browser.xul
chrome://securelogin/skin/secureLogin1.5.css
appversion<2.0
style chrome://securelogin/content/secureLoginOptions.xul
chrome://securelogin/skin/secureLoginOptions1.5.css appversion<2.0
diff -r 87508a3527d0 chrome/content/secureLogin.js
--- a/chrome/content/secureLogin.js Sat Aug 06 18:58:22 2011 +0300
+++ b/chrome/content/secureLogin.js Sat Aug 06 19:25:52 2011 +0300
@@ -187,7 +187,7 @@
// Disable the prefilling of login forms if enabled, remember
status:
try {
var rootPrefBranch =
this.getPrefManager().getBranch('');
-
if(this.getVersionComparator().compare(this.getAppInfo().version, '2.*') < 0) {
+
if(this.getVersionComparator().compare(this.getAppInfo().platformVersion,
'1.8.*') < 0) {
// Firefox version 1.5 - 2.0.0.*:
if(rootPrefBranch.getBoolPref('signon.prefillForms')) {
rootPrefBranch.setBoolPref('signon.prefillForms', false);
@@ -1994,7 +1994,7 @@
url = doc.location.href +
this.secureLoginPrefs.getCharPref('secureLoginBookmarkHash');
}
-
if(this.getVersionComparator().compare(this.getAppInfo().version, '2.*') < 0) {
+
if(this.getVersionComparator().compare(this.getAppInfo().platformVersion,
'1.8.*') < 0) {
// Firefox version 1.5 - 2.0.0.*:
var bookmarkArguments = {
name: doc.title,
@@ -2483,7 +2483,7 @@
finalizeSignonAutofillFormsStatus: function() {
// Re-enable the prefilling of login forms if setting has been
true:
try {
-
if(this.getVersionComparator().compare(this.getAppInfo().version, '2.*') < 0) {
+
if(this.getVersionComparator().compare(this.getAppInfo().platformVersion,
'1.8.*') < 0) {
// Firefox version 1.5 - 2.0.0.*:
if(this.autofillForms) {
this.getPrefManager().getBranch('').setBoolPref('signon.prefillForms', true);
diff -r 87508a3527d0 chrome/content/secureLoginOverlay.xul
--- a/chrome/content/secureLoginOverlay.xul Sat Aug 06 18:58:22 2011 +0300
+++ b/chrome/content/secureLoginOverlay.xul Sat Aug 06 19:25:52 2011 +0300
@@ -17,68 +17,71 @@
/>
</stringbundleset>
<menupopup id="menu_ToolsPopup">
- <menu
- id="secureLoginToolsMenu"
- label="&toolsmenu.label;"
- class="menu-iconic secureLoginIcon"
- insertbefore="javascriptConsole">
- <menupopup
- id="secureLoginToolsMenuPopup"
- onpopupshowing="secureLogin.toolsMenu(event);">
- <menu
-
id="secureLoginToolsMenuAutofillFormsMenu"
- label="&autofillformsmenu.label;"
- class="menu-iconic autofillFormsIcon"
- hidden="true">
- </menu>
- <menuseparator
-
id="secureLoginToolsMenuAutofillFormsMenuSeparator"
- hidden="true"
- />
- <menuitem
- id="secureLoginOptionsToolsMenuItem"
- label="&menuoptions.label;"
- class="menuitem-iconic
secureLoginSettingsIcon"
-
oncommand="secureLogin.showDialog('chrome://secureLogin/content/secureLoginOptions.xul');"
- />
- <menuseparator/>
- <menuitem
-
id="secureLoginJavascriptProtectionToolsMenuItem"
-
observes="secureLoginJavascriptProtection"
- />
- <menuitem
- id="secureLoginExceptionsToolsMenuItem"
- label="&menuexceptions.label;"
-
oncommand="secureLogin.showDialog('chrome://secureLogin/content/secureLoginExceptions.xul');"
- />
- <menuseparator/>
- <menuitem
- id="secureLoginPasswordsToolsMenuItem"
- label="&menupasswords.label;"
-
oncommand="secureLogin.showPasswordManager();"
- />
- <menuitem
-
id="secureLoginPasswordsExceptionsToolsMenuItem"
- class="minVersion2"
- label="&menupassexceptions.label;"
-
oncommand="secureLogin.showDialog('chrome://passwordmgr/content/passwordManagerExceptions.xul');"
- />
- <menuseparator/>
- <menuitem
- id="secureLoginBookmarkToolsMenuItem"
- label="&addsecureloginbookmark.label;"
-
oncommand="secureLogin.showBookmarkDialog();"
- />
- <menuseparator/>
- <menuitem
- id="secureLoginHelpToolsMenuItem"
- label="&help.label;"
- class="menuitem-iconic
secureLoginHelpIcon"
- oncommand="secureLogin.openHelp();"
- />
- </menupopup>
- </menu>
+ <menu id="secureLoginToolsMenu"
insertbefore="javascriptConsole"/>
</menupopup>
+ <menupopup id="taskPopup">
+ <menu id="secureLoginToolsMenu"
insertbefore="menu_passwordManager"/>
+ </menupopup>
+ <menu
+ id="secureLoginToolsMenu"
+ label="&toolsmenu.label;"
+ class="menu-iconic secureLoginIcon">
+ <menupopup
+ id="secureLoginToolsMenuPopup"
+ onpopupshowing="secureLogin.toolsMenu(event);">
+ <menu
+ id="secureLoginToolsMenuAutofillFormsMenu"
+ label="&autofillformsmenu.label;"
+ class="menu-iconic autofillFormsIcon"
+ hidden="true">
+ </menu>
+ <menuseparator
+
id="secureLoginToolsMenuAutofillFormsMenuSeparator"
+ hidden="true"
+ />
+ <menuitem
+ id="secureLoginOptionsToolsMenuItem"
+ label="&menuoptions.label;"
+ class="menuitem-iconic secureLoginSettingsIcon"
+
oncommand="secureLogin.showDialog('chrome://secureLogin/content/secureLoginOptions.xul');"
+ />
+ <menuseparator/>
+ <menuitem
+
id="secureLoginJavascriptProtectionToolsMenuItem"
+ observes="secureLoginJavascriptProtection"
+ />
+ <menuitem
+ id="secureLoginExceptionsToolsMenuItem"
+ label="&menuexceptions.label;"
+
oncommand="secureLogin.showDialog('chrome://secureLogin/content/secureLoginExceptions.xul');"
+ />
+ <menuseparator/>
+ <menuitem
+ id="secureLoginPasswordsToolsMenuItem"
+ label="&menupasswords.label;"
+ oncommand="secureLogin.showPasswordManager();"
+ />
+ <menuitem
+ id="secureLoginPasswordsExceptionsToolsMenuItem"
+ class="minVersion2"
+ label="&menupassexceptions.label;"
+
oncommand="secureLogin.showDialog('chrome://passwordmgr/content/passwordManagerExceptions.xul');"
+ />
+ <menuseparator/>
+ <menuitem
+ id="secureLoginBookmarkToolsMenuItem"
+ label="&addsecureloginbookmark.label;"
+ oncommand="secureLogin.showBookmarkDialog();"
+ />
+ <menuseparator/>
+ <menuitem
+ id="secureLoginHelpToolsMenuItem"
+ label="&help.label;"
+ class="menuitem-iconic secureLoginHelpIcon"
+ oncommand="secureLogin.openHelp();"
+ />
+ </menupopup>
+ </menu>
<window id="main-window">
<popupset id="secureLoginPopUpSet">
<tooltip
diff -r 87508a3527d0 install.rdf
--- a/install.rdf Sat Aug 06 18:58:22 2011 +0300
+++ b/install.rdf Sat Aug 06 19:25:52 2011 +0300
@@ -17,6 +17,14 @@
<em:maxVersion>6.*</em:maxVersion>
</Description>
</em:targetApplication>
+ <em:targetApplication>
+ <Description>
+ <!-- SeaMonkey -->
+
<em:id>{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}</em:id>
+ <em:minVersion>2.2</em:minVersion>
+ <em:maxVersion>2.3.*</em:maxVersion>
+ </Description>
+ </em:targetApplication>
<em:translator>Fingli (Bulgarian)</em:translator>
<em:translator>PetrTwo (Czech)</em:translator>
<em:translator>Oliver Roth (German)</em:translator>
_______________________________________________
support-seamonkey mailing list
[email protected]
https://lists.mozilla.org/listinfo/support-seamonkey
