Hello, On Fri, Mar 30, 2012 at 9:27 PM, Aaron Meurer <[email protected]> wrote: > > I'd love to hear any thoughts on how we can better achieve this, as > well as any other anti-patterns you've noticed that lead to these > large branches.
When I started learning a version control system, I was told innumerable times to do small, atomic commits. Still, it took me about half a year to realise that small, atomic commits really means *small* and *atomic* commits. I think the problem with sending pull requests earlier may be similar. I am afraid I cannot say I have noticed a general pattern, because I haven't really watched anyone, so I'll just share my own experience. A small pull request is really a small pull request, which makes a slight step towards the goal. It is not okay to have three pull request of 30 commits each; but it is okay to 12 pull request with 5 commits each. An important technique I have once noticed to work for me is that, instead of trying to guess how "large" a small pull request is, one should start guessing how "small" a small pull request is. That is, better make a smaller pull request and hear someone suggest adding a couple commits. This is always way better than having to review and then merge a large number of commits. That's my personal experience :-) I hope it's not far from being true :-) Sergiu -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
