On 01.04.2012 13:08, Joachim Durchholz wrote:
Am 31.03.2012 11:59, schrieb Tom Bachmann:
I think it may be helpful to give an explicit ballpark estimate of
maximal desired pull request size, e.g. 10 commits.
If a ballpark figure it is, give one in terms of lines of added code. Or
in terms of days of raw coding (and warn that 1 day of coding may mean
3-5 days total since it includes thinking, discussing, and correcting).
Some of my commits were several hundred lines. A pull request with ten
commits of that size, and it's very probably entire unmergeable, and
most certainly not reviewable.
True. Then let's think about LOC.
- https://github.com/sympy/sympy/pull/1190
~700 additions. I believe this PR should actually be still on the "easy
to review" side.
- https://github.com/sympy/sympy/pull/1001
~200 lines changed. Very managable, but it changes existing code in
delicate ways, so I would say this is not much easier than the previous one.
- https://github.com/sympy/sympy/pull/999
~150 lines changed. Perfect size.
- https://github.com/sympy/sympy/pull/504
https://github.com/sympy/sympy/pull/378
> 5000 lines changed. Definitely not my best work in chopping up pull
requests...
- https://github.com/sympy/sympy/pull/316
~800 lines changed. Still managable size, imho.
- https://github.com/sympy/sympy/pull/236
~ 1300 lines changed. I remember this was a pain to get reviewed (but
managable compared to the heroic effort Aaron had to put into my gsoc PRs).
Obviously these assessments are all only my personal taste. But it seems
to me we should discourage pull requests > 1000 lines of code, and
encourage about 300 lines. Obviously there should exceptions.
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sympy?hl=en.
