On Sun, Apr 1, 2012 at 2:26 PM, Joachim Durchholz <[email protected]> wrote: > Am 01.04.2012 22:10, schrieb Aaron Meurer: > >> I personally think that lines of code should not be used as a metric >> for almost anything, and certainly not anything relating to the >> complexity of the code. The reason is that some lines of code are >> much more complex than others, and the difference is great. > > > True. > > >> Even if >> >> we make the obvious split between documentation (docstrings, comments, >> whitespace) and real code, > > > That would be trying to make a measurement precise that never can be. > Remember this is for a ballpark figure; we can always make exceptions. > > >> there is still a big difference, and it >> >> will vary from person to person. A class with a bunch of simple >> properties may take up many lines (say 100), but will be very simple. >> A complex function, may be only 20 lines. Furthermore, improved >> documentation may have the result of making the code easier to read, >> even though it makes things longer. > > > Exactly. > Code that's hard to understand has longer commentary (if it is of any > quality). > In the end, if you include comments, the LoC count per function point is > roughly constant. > VERY roughly constant, of course. We're talking ballpark figures and orders > of magnitude, and we'll always be able to make exceptions. > > >> I don't think it's unreasonable to just say "atomic" change. > > > You'll have to explain what "atomic" is. This can range from five-liners to > five-thousand-liners.
That's my point exactly. Aaron Meurer > > >> By the way, another thing that we should encourage is to submit >> orthogonal changes as separate pull requests. If the GSoC student has >> to fix some bug in some other module from the one he is mainly working >> on for his project, that fix should go in a separate branch. This can >> then be reviewed quickly and merged into master, and then he can just >> base his main work off of master. > > > Agreed. > > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
