Am 01.04.2012 21:48, schrieb Tom Bachmann:
But it seems
to me we should discourage pull requests > 1000 lines of code, and
encourage about 300 lines. Obviously there should exceptions.

Hm... given the general tendency to err on the "too large" size, it's probably best to communicate a relatively low limit, but be generous with exceptions.
(I have my own too-large pull requests...)

Draft:
"Keep your pull requests small. Ideally, it should not be more than 300 lines of code added, and you'll raise eyebrows if it is more than 500 lines."

--
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sympy?hl=en.

Reply via email to