On Wed, Apr 4, 2012 at 9:38 AM, Joachim Durchholz <[email protected]> wrote: > Am 02.04.2012 08:15, schrieb Aaron Meurer: > >> I was thinking that XYZ would be something along the lines of a >> passing test suite for the function. That may sound silly, but this >> is exactly when the code works, which means that it can be submitted. >> If the tests don't pass (assuming you've written all test cases >> already), then you still need to work on the code. > > That's a definition of "production-ready" - which, of course, any pull > request must satisfy to go in. > > It's not a definition of "atomic" though. A 50,000-line pull request can > have a complete test suite and pass all tests, yet I'd hardly consider such > a thing atomic.
How about "the smallest production ready"? I think that's what Aaron meant. Sergiu -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
