Vinay Devadas wrote: > Sorry, the link I sent previously was not visible to people > outside sun. Here the pointer to the webrev on opensolaris. > > http://cr.opensolaris.org/~vdevadas/turbo/ > > -vinay
This patch depends on your change in cpudrv. Could you please post it on cr.opensolaris.org as well? So turbo mode is supported in PowerTOP after ON integrates your patch against cpudrv. I think you need to introduce a probe mechanism here, so that PowerTOP output is not broken when turbo mode is supported on the hardware but solaris kernel does not support your new cpudrv driver. BTW, some coding style issue. Line 60, 91, 100, 134, 150, 160 have trailing white space/tab, and a lot in ida.c. Rafael did a great job to eliminate these problem, please make sure not to introduce it again. Thanks, -Aubrey
