Vinay Devadas wrote: >> No, it didn't. >> if cpudrv is failed to open, We don't want to see the P-state report >> broken. >> > > http://cr.opensolaris.org/~vdevadas/turbo1/ > > I have fixed this and tested it, I did not see Pstate report > getting broken when cpudrv failed to open. There are only very > minor changes in ida.c. Take a look and let me know if it resolved > your concern. >
Another issue: when IDA is enabled, if DTrace says we are in P0, we really in P0 in terms of OSPM. So not necessary to change p-state index and percent. Others look good, except I didn't see the change of cpudrv and may miss the problem of related implementation in PowerTOP, and coding style issues. Thanks, -Aubrey
