> when IDA is enabled, if DTrace says we are in P0, > we really in P0 in terms of OSPM. So not necessary to change p-state > index and percent. >
Even when IDA is enabled and Dtrace says we are in P0, the ratio APERF/MPERF *may be* <=1. This means we were just running at max non turbo frequency (marketed as P1) and not actually in turbo mode (marketed as P0). Therefore it is necessary to change p-state index and percent and do check. Correct me if I am wrong. > Others look good, except I didn't see the change of cpudrv Here is the link to the cpudrv stuff. http://cr.opensolaris.org/~vdevadas/cpudrv/ -Vinay ----- Original Message ----- From: "Li, Aubrey" <[email protected]> Date: Wednesday, August 13, 2008 8:43 pm Subject: Re: [tesla-dev] PowerTop must support Turbo mode: webrev link onopensolaris To: Vinay Devadas <Vinay.Devadas at Sun.COM> Cc: tesla-dev at opensolaris.org > Vinay Devadas wrote: > > >> No, it didn't. > >> if cpudrv is failed to open, We don't want to see the P-state report > >> broken. > >> > > > > http://cr.opensolaris.org/~vdevadas/turbo1/ > > > > I have fixed this and tested it, I did not see Pstate report > > getting broken when cpudrv failed to open. There are only very > > minor changes in ida.c. Take a look and let me know if it resolved > > your concern. > > > > Another issue: > > when IDA is enabled, if DTrace says we are in P0, > we really in P0 in terms of OSPM. So not necessary to change p-state > index and percent. > > Others look good, except I didn't see the change of cpudrv and may miss > the problem of related implementation in PowerTOP, and coding style > issues. > > Thanks, > -Aubrey > _______________________________________________ > tesla-dev mailing list > tesla-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/tesla-dev
