> No, it didn't. > if cpudrv is failed to open, We don't want to see the P-state > report broken. >
http://cr.opensolaris.org/~vdevadas/turbo1/ I have fixed this and tested it, I did not see Pstate report getting broken when cpudrv failed to open. There are only very minor changes in ida.c. Take a look and let me know if it resolved your concern. Thanks, Vinay ----- Original Message ----- From: "Li, Aubrey" <[email protected]> Date: Wednesday, August 13, 2008 5:30 pm Subject: RE: [tesla-dev] PowerTop must support Turbo mode: webrev link onopensolaris To: Vinay Devadas <Vinay.Devadas at Sun.COM> Cc: tesla-dev at opensolaris.org > Vinay Devadas wrote: > > > Hi, > > > > ----- Original Message ----- > > From: "Li, Aubrey" <aubrey.li at intel.com> > > Date: Tuesday, August 12, 2008 10:43 pm > > Subject: Re: [tesla-dev] PowerTop must support Turbo mode: > > webrev link onopensolaris > > To: Vinay Devadas <Vinay.Devadas at Sun.COM>, tesla-dev at opensolaris.org > > > > > >> Vinay Devadas wrote: > >> > >>> Sorry, the link I sent previously was not visible to people > >>> outside sun. Here the pointer to the webrev on opensolaris. > >>> > >>> http://cr.opensolaris.org/~vdevadas/turbo/ > >>> > >>> -vinay > >> > >> This patch depends on your change in cpudrv. > >> Could you please post it on cr.opensolaris.org as well? > >> > > > > > > http://cr.opensolaris.org/~vdevadas/cpudrv/ > > > > > >> So turbo mode is supported in PowerTOP after ON integrates > >> your patch against cpudrv. I think you need to introduce a probe > >> mechanism here, so that PowerTOP output is not broken when > >> turbo mode is supported on the hardware but solaris kernel does > >> not support your new cpudrv driver. > >> > > > > This is already taken care off. the Ida_flag in ida.c will > > remain 0, if it fails opening the cpudrv device file for ioctl. > > > > No, it didn't. > if cpudrv is failed to open, We don't want to see the P-state > report broken. > > Thanks, > -Aubrey > > =============================================== > $ pfexec ./amd64/powertop -d 1 > OpenSolaris PowerTOP 1.1 (C) 2007 Intel Corporation > > Intel Dynamic Acceleration Enabled > powertop: Failed to open cpu at 0:ctrl > Collecting data for 5.00 second(s) > powertop: Failed to open cpu at 0:ctrl > Cn Avg residency > C0 (cpu running) (49.9%) > C1 0.4ms (50.1%) > P-states (frequencies) > 1596 Mhz 0.0% > 1729 Mhz 0.0% > 1862 Mhz 0.0% > 1995 Mhz 0.0% > 2128 Mhz 0.0% > 2261 Mhz 0.0% > 2394 Mhz 0.0% > 2527 Mhz 0.0% > 2660 Mhz 0.0% > 2793 Mhz 0.0% > 2926 Mhz 12.5% > 0.0 hz 87.5% <======================= > Wakeups-from-idle per second: 2477.8 interval: 5.0s
