Vinay Devadas wrote: > Hi, > > ----- Original Message ----- > From: "Li, Aubrey" <aubrey.li at intel.com> > Date: Tuesday, August 12, 2008 10:43 pm > Subject: Re: [tesla-dev] PowerTop must support Turbo mode: webrev link > onopensolaris > To: Vinay Devadas <Vinay.Devadas at Sun.COM>, tesla-dev at opensolaris.org > > >> Vinay Devadas wrote: >> >>> Sorry, the link I sent previously was not visible to people >>> outside sun. Here the pointer to the webrev on opensolaris. >>> >>> http://cr.opensolaris.org/~vdevadas/turbo/ >>> >>> -vinay >> This patch depends on your change in cpudrv. >> Could you please post it on cr.opensolaris.org as well? >> > > > http://cr.opensolaris.org/~vdevadas/cpudrv/ > > >> So turbo mode is supported in PowerTOP after ON integrates >> your patch against cpudrv. I think you need to introduce a probe >> mechanism here, so that PowerTOP output is not broken when >> turbo mode is supported on the hardware but solaris kernel does >> not support your new cpudrv driver. >> > > This is already taken care off. the Ida_flag in ida.c will remain 0, if it > fails opening the cpudrv device file for ioctl. > >> BTW, some coding style issue. >> Line 60, 91, 100, 134, 150, 160 have trailing white space/tab, >> and a lot in ida.c. Rafael did a great job to eliminate these problem, >> please make sure not to introduce it again. >> > > Yes, sure i will set this right.
Make sure both patches clear lint as well. Rafael > > -vinay > >> Thanks, >> -Aubrey >> _______________________________________________ >> tesla-dev mailing list >> tesla-dev at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/tesla-dev > _______________________________________________ > tesla-dev mailing list > tesla-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/tesla-dev
