Danek Duvall wrote:
On Tue, Mar 24, 2009 at 03:51:55PM -0600, Mark J. Nelson wrote:

http://cr.opensolaris.org/~mjnelson/webrev.its.2.swan/

*Very* quick scan:

webrev.sh:

  - line 1045: is "=~" functional in ksh88?

No.

I suppose I should change this, rather than just updating the script to specify ksh93 as the interpreter.

  - line 2264: Why not just use an if statement?

Developmental history. Thought there were going to be multiple break points. It's more clear as an "if," with similar comments and intentional failure to indent.

--Mark
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org

Reply via email to