On Wed, Mar 25, 2009 at 04:43:33PM -0600, Mark J. Nelson wrote:
> http://cr.opensolaris.org/~mjnelson/webrev.its.3/
All of these are nits:
webrev.sh:
- line 2673: Is there a particular reason that the conf files are
cumulative while the registry files aren't? It seems to me that it'd
be nice to add to the registry without having to duplicate it.
- line 2688: While there's no real danger here, eval always scares me.
Since you only anticipate two variables here, you could do the same
thing you do for the registry file, and simply set the two variable
explicitly, based on the names that are read in.
- line 2725: Why define an EXTERNAL_URL in the registry when you could
just define URL, and then you wouldn't need this block?
Danek
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
