Note: I'm looking for an explicit "I reviewed this carefully, and it
looks good," which I don't think I've gotten from anybody yet. I was
hoping for this build, but I'm on vacation all of next week, so if I
don't get review by midday tomorrow, I'll push it back.
This really should be the last round:
http://cr.opensolaris.org/~mjnelson/webrev.its.3/
http://cr.opensolaris.org/~mjnelson/webrev.its.incr.1-3/
http://cr.opensolaris.org/~mjnelson/webrev.its.incr.2-3/
...hopefully the naming scheme is obvious.
Explanation of the webrev.sh changes from round 1 to 3:
1045: response to Danek, to make it work for ksh88
1069-1074: I should have been my own first reviewer.
2081-2227: filename and option letter change in response to design
review comments from Alan and Darren
2257-2272, 2632-2636, 2752-2757: I got really, really annoyed with
repeated invocations doing tons of unnecessary work. So I slipped this
stuff into revision 2, and then cleaned it up per my subsequent exchange
with Danek.
2637-2750: this is all of the new logic, reorganized per the
do_everything changes. Really, incrementally, what changed was the
its.conf file processing, and the {IN|EX}TERNAL_URL{_domain} stuff. The
changes from "~" to "$HOME" were in response to testing, where some
quoting issues were causing ~ to not expand correctly inside the
its.conf processing loop. Some of these changes are more obvious from
the 2-3 incremental.
So I've addressed all code review comments received to date, and tested
everything I touched.
--Mark
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
