Am 11.09.2007 um 10:25 schrieb Christian Boos: > I'd like to reach a decision for ticket #5572 (Roadmap Progress bar > errors when using custom Workflow). Again a bug report that turned > into > a new feature ;-) [snip] > Opinions?
I agree with you in general, but maybe we can still simplify the change a bit. Specifically, do we really need the wildcard and negation support for specifying the list of statuses? People won't have 50 different statuses (and if they do, they deserve some punishment ;) ), and you really don't need to go in and edit the grouping configuration all the time. So I think that using just a plain list of status names would be sufficient, and simplify the code (and documentation). That would also remove the reliance on the order of the options if I'm not mistaken. Some other minor nits: * Naming of the "all_status" and "remaining_status" variables: I'd prefer the more common plural of "statuses" here :) * The .css option: I think "css_class" would be more intuitive/explicit * The .args option: Not sure about this one... first, the name should probably be "query_args" to be more descriptive. And that you separate options with a comma is not really intuitive, as it looks like a query string; I would've first tried using "&" there :P But that's something that can be fixed by a slight change to the documentation. Cheers, Chris -- Christopher Lenz cmlenz at gmx.de http://www.cmlenz.net/ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
