Am 11.09.2007 um 17:50 schrieb Christian Boos: > Christopher Lenz wrote: >> Am 11.09.2007 um 10:25 schrieb Christian Boos: >>> I'd like to reach a decision for ticket #5572 (Roadmap Progress bar >>> errors when using custom Workflow). Again a bug report that turned >>> into >>> a new feature ;-) >> [snip] >>> Opinions? >> >> I agree with you in general, but maybe we can still simplify the >> change a bit. >> >> Specifically, do we really need the wildcard and negation support for >> specifying the list of statuses? People won't have 50 different >> statuses (and if they do, they deserve some punishment ;) ), and you >> really don't need to go in and edit the grouping configuration all >> the time. So I think that using just a plain list of status names >> would be sufficient, and simplify the code (and documentation). That >> would also remove the reliance on the order of the options if I'm not >> mistaken. > Negation support was there for being able to specify things like > "anything but closed". > A wildcard is useful for specifying a catch-all group, useful when you > upgraded the workflow a few times and you are unsure about what are > the > remaining states. > However the first use case could probably be subsumed by the second > and > we'd only need one catch-all group after all. > So yes, I think the patch can be simplified further in this area. > The .order is still needed I think, in order to have control over the > sequence of the groups within the progress bar.
Hmm, I'm not sure whether you understood me correctly here ;) I understand what the wildcard and negation stuff was intended for; I'm arguing that they are overkill for this case. I.e. instead of: [milestone-groups] closed = closed open = * we should simply require people to explicitly list all the statuses: [milestone-groups] closed = closed open = new, assigned, reopened My argument is that people shouldn't have *that* many statuses, and even if they do they won't be editing this configuration on a daily basis. (And eventually we should probably have an admin panel for this anyway.) And I wasn't arguing about removing .order, we need that. I meant that if we drop negation *and* wildcards, we don't need to rely on the options being in any particular order in the configuration file. I.e. in the second example, you could move the "open =" line above the "closed = " line, and it'd still work. Plus this *might* convince Noah that the change is simple enough for core ;) Anyway, hope that clarifies my comments. Another question: is it possible to set the "label" of the milestone groups through this configuration? I.e. the "Active tickets" and "Completed tickets" strings? If not, what is going to get displayed? Cheers, Chris -- Christopher Lenz cmlenz at gmx.de http://www.cmlenz.net/ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
