On Tuesday 11 September 2007, Christian Boos wrote: > > Hello, > > I'd like to reach a decision for ticket #5572 (Roadmap Progress bar > errors when using custom Workflow). Again a bug report that turned into > a new feature ;-) > > More seriously, the motivation here was to match the flexibility offered > by the ConfigurableTicketWorkflow. As you know, with the stock > ITicketActionController you can define simple customized workflow, and > define new ticket states in the config files. I think it would be > suboptimal to /not/ have the possibility to be able to tell how those > new states should be grouped in the milestone display. > > Hence the following patch: > http://trac.edgewall.org/attachment/ticket/5572/milestone_groups-r5946.diff > > which was refined a few times by me and ecarter. > Noah expressed his concerns that this would be too much for Trac core. > > A simpler fix would be possible (one group for closed tickets, a second > for all the other states), but as I said above I think it's just at the > appropriate level of complexity, matching the workflow configurability.
Not only is it possible, but I committed that fix to trunk a while back http://trac.edgewall.org/changeset/5842 (and re-diffed the feature patch afterwards). 2-line change. :) I do think the feature is useful. With the new workflow, you could easily have three groups: closed, in-work, and everything else. (As in fact, you have in the workflows/basic-workflow.ini example.) Based on that use case, I agree we need a wildcard capability. The r6000 diff still has a reference to '!'. Otherwise, the patch looks ok to me. As an aside though, the "bug report that turned into a new feature" bothered me on this one. I think the 2-line fix for the defect should have gone in quickly (the ticket was filed 6/21, and the small fix was 3 weeks later on 7/16), with a new enhancement filed for the feature. And yes, I was to blame. Still bugs me. :) Eli --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
