> catch ( ClassNotFoundException e )
> {
> +            e.printStackTrace();
> throw new Exception ( "Requested Screen not found: " + name );
> }
> return screen;

Kevin,

I'm -1 on this change because it is something that should be caught higher
up. You should catch that exception somewhere else...because it has a "nice"
error message in it. If you want to print a stack trace from that exception
later on, then that is fine (it is usually done from within the Turbine
servlet directly, but i can see you wanting to do it elsewhere), but I don't
think it should happen there.

Please back that change out. I also really do not want to clutter the code
up with a bunch of printStackTraces()...that was one of the motivations
behind Turbine in the first place. Preventing that and catching errors in
one single location to prevent this.

-jon

-- 
Come to the first official Apache Software Foundation
Conference!  <http://ApacheCon.Com/>




------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Problems?:           [EMAIL PROTECTED]

Reply via email to