kevin's recent changes have strange logic according to his comments. this
diff that I just created, but have no checked in seems to make more
sense...as well as maintain the current coding conventions as well as tell
the system to throw an error that will be shown to the user.

comments?

-jon


cvs -z9 diff Turbine.java (in directory
D:\Projects\Servlets\turbine\src\java\)
Index: Turbine.java
===================================================================
RCS file: /products/cvs/turbine/turbine/src/java/Turbine.java,v
retrieving revision 1.35
diff -r1.35 Turbine.java
198,202c198,200
< 
<                 //make sure that this URL you are about to redirect to is
not 
<                 //the current URL.  If it is and you redirect to it you
will
<                 //get caught in an infinite redirect loop
< 
---
>                 // make sure that this URL you are about to redirect to is not
>                 // the current URL.  If it is and you redirect to it you will
>                 // get caught in an infinite redirect loop
204,205c202,209
< 
<                 if ( duri.toString().equals(currentURI) ) {
---
>                 if ( duri.toString().equals(currentURI) )
>                 {
>                     log("Infinite redirect detected...");
>                     Log.error ("Infinite redirect detected...");
>                     throw new Exception ("Infinite redirect detected...");
>                 }
>                 else
>                 {
208,209d211
<                 } else {
<                     log("Infinite redirect detected...correcting...");
211,212d212
< 
< 

    
-- 
Come to the first official Apache Software Foundation
Conference!  <http://ApacheCon.Com/>




------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Problems?:           [EMAIL PROTECTED]

Reply via email to