jon * wrote:
>
> kevin's recent changes have strange logic according to his comments. this
> diff that I just created, but have no checked in seems to make more
> sense...as well as maintain the current coding conventions as well as tell
> the system to throw an error that will be shown to the user.
Comment change is fine.
I am not sure the user should see this Exception. Just display the
current URL. That is why it is defensive programming :)
I started to experience this infinite redir recently so it is either
Turbine or Jakarta. I am still in the process of tracking down the bug.
Kevin
>
> cvs -z9 diff Turbine.java (in directory
> D:\Projects\Servlets\turbine\src\java\)
> Index: Turbine.java
> ===================================================================
> RCS file: /products/cvs/turbine/turbine/src/java/Turbine.java,v
> retrieving revision 1.35
> diff -r1.35 Turbine.java
> 198,202c198,200
> <
> < //make sure that this URL you are about to redirect to is
> not
> < //the current URL. If it is and you redirect to it you
> will
> < //get caught in an infinite redirect loop
> <
> ---
> > // make sure that this URL you are about to redirect to is not
> > // the current URL. If it is and you redirect to it you will
> > // get caught in an infinite redirect loop
> 204,205c202,209
> <
> < if ( duri.toString().equals(currentURI) ) {
> ---
> > if ( duri.toString().equals(currentURI) )
> > {
> > log("Infinite redirect detected...");
> > Log.error ("Infinite redirect detected...");
> > throw new Exception ("Infinite redirect detected...");
> > }
> > else
> > {
> 208,209d211
> < } else {
> < log("Infinite redirect detected...correcting...");
--
Kevin A Burton
Senior Software Engineer
Kendara Inc
http://www.kendara.com
Mobile: 408-910-6145
Linux - The revolution will NOT be televised
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
