Hi Johan, On 5/31/2026 11:03 PM, Johan Jonker wrote: > Make reset-rockchip available for use with dwc2 phy > in SPL to load U-boot (full) from a USB disk.
This does not seem to match what the patch does. The patch seem to do the opposite, make it possible to disable inclusion of reset driver in SPL. > > Signed-off-by: Johan Jonker <[email protected]> > --- > drivers/reset/Kconfig | 9 +++++++++ > drivers/reset/Makefile | 4 ++-- > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > index 66911199c8ba..10aa1ee9598b 100644 > --- a/drivers/reset/Kconfig > +++ b/drivers/reset/Kconfig > @@ -100,6 +100,15 @@ config RESET_ROCKCHIP > though is that some reset signals, like I2C or MISC reset multiple > devices. > > +config SPL_RESET_ROCKCHIP > + bool "Reset controller driver for Rockchip SoCs in SPL" > + depends on SPL_DM_RESET && ARCH_ROCKCHIP && SPL_CLK > + default n Default should likely make this default RESET_ROCKCHIP to match existing behavior before this patch. > + help > + Support for reset controller on rockchip SoC. The main limitation > + though is that some reset signals, like I2C or MISC reset multiple > + devices. > + > config RESET_HSDK > bool "Synopsys HSDK Reset Driver" > depends on DM_RESET && TARGET_HSDK > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile > index 088545c64733..afb54b24ac95 100644 > --- a/drivers/reset/Makefile > +++ b/drivers/reset/Makefile > @@ -3,7 +3,7 @@ > # Copyright (c) 2016, NVIDIA CORPORATION. > # > > -obj-$(CONFIG_DM_RESET) += reset-uclass.o > +obj-$(CONFIG_$(PHASE_)DM_RESET) += reset-uclass.o This could have affects on many other platforms/devices and should likely be in a separate patch, if this really is needed. Regards, Jonas > obj-$(CONFIG_SANDBOX_MBOX) += sandbox-reset.o > obj-$(CONFIG_SANDBOX_MBOX) += sandbox-reset-test.o > obj-$(CONFIG_STI_RESET) += sti-reset.o > @@ -16,7 +16,7 @@ obj-$(CONFIG_RESET_BCM6345) += reset-bcm6345.o > obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o > obj-$(CONFIG_RESET_AST2500) += reset-ast2500.o > obj-$(CONFIG_RESET_AST2600) += reset-ast2600.o > -obj-$(CONFIG_RESET_ROCKCHIP) += reset-rockchip.o rst-rk3506.o rst-rk3528.o > rst-rk3576.o rst-rk3588.o > +obj-$(CONFIG_$(PHASE_)RESET_ROCKCHIP) += reset-rockchip.o rst-rk3506.o > rst-rk3528.o rst-rk3576.o rst-rk3588.o > obj-$(CONFIG_RESET_MESON) += reset-meson.o > obj-$(CONFIG_RESET_SOCFPGA) += reset-socfpga.o > obj-$(CONFIG_RESET_MEDIATEK) += reset-mediatek.o > -- > 2.39.5 >
