Hi Johan, On 5/31/2026 11:03 PM, Johan Jonker wrote: > Make phy-rockchip-usb2 available as phy for dwc2 USB > in SPL to load U-boot (full) from a USB disk.
This patch can be merged with the addition of the new phy driver, why the need to keep it separate? > > Signed-off-by: Johan Jonker <[email protected]> > --- > drivers/phy/rockchip/Kconfig | 10 ++++++++++ > drivers/phy/rockchip/Makefile | 2 +- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig > index 745e0ea67b8d..754b178a0bbb 100644 > --- a/drivers/phy/rockchip/Kconfig > +++ b/drivers/phy/rockchip/Kconfig > @@ -60,6 +60,16 @@ config PHY_ROCKCHIP_USB2 > bool "Rockchip USB2 PHY" > depends on ARCH_ROCKCHIP > select PHY > + select RESET_ROCKCHIP The code in driver did not seem to depend on the reset feature, so we should likely not need to select the RESET_ROCKCHIP driver here, if you think it is needed, please only imply and try the driver compiles with RESET_ROCKCHIP=n. Regards, Jonas > + help > + Support for Rockchip USB 2.0 PHY. > + > +config SPL_PHY_ROCKCHIP_USB2 > + bool "Rockchip USB2 PHY in SPL" > + depends on ARCH_ROCKCHIP && SPL > + default n > + select SPL_PHY > + select SPL_RESET_ROCKCHIP > help > Support for Rockchip USB 2.0 PHY. > > diff --git a/drivers/phy/rockchip/Makefile b/drivers/phy/rockchip/Makefile > index f296dc8f3d2a..c5577dfe86e8 100644 > --- a/drivers/phy/rockchip/Makefile > +++ b/drivers/phy/rockchip/Makefile > @@ -10,5 +10,5 @@ obj-$(CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY) += > phy-rockchip-naneng-combphy.o > obj-$(CONFIG_PHY_ROCKCHIP_PCIE) += phy-rockchip-pcie.o > obj-$(CONFIG_PHY_ROCKCHIP_SNPS_PCIE3) += phy-rockchip-snps-pcie3.o > obj-$(CONFIG_PHY_ROCKCHIP_TYPEC) += phy-rockchip-typec.o > -obj-$(CONFIG_PHY_ROCKCHIP_USB2) += phy-rockchip-usb2.o > +obj-$(CONFIG_$(PHASE_)PHY_ROCKCHIP_USB2) += phy-rockchip-usb2.o > obj-$(CONFIG_PHY_ROCKCHIP_USBDP) += phy-rockchip-usbdp.o > -- > 2.39.5 >
