Hi Quentin, Il giorno mer 14 ott 2026 alle ore 18:25 Quentin Schulz <[email protected]> ha scritto: > > Hi Massimo, > > On 10/2/26 6:36 PM, Massimo Pegorer wrote: > > The configuration options SPL_BSS_START_ADDR and SPL_BSS_MAX_SIZE are > > guarded by SPL_HAS_BSS_LINKER_SECTION and SPL_BSS_LIMIT options in the > > common/spl/Kconfig file where they are originally defined. Addition of > > a second config statement without 'depends on' guard causes these two > > options to be put in the configuration even when the guard is not > > selected, which is unneeded and sounds wrong. > > > > I'm sorry, I don't understand the issue. Can you clarify or provide a > way to reproduce the issue? Multiple definitions of the same Kconfig > symbol are "combined" as far as I know so this shouldn't be an issue.
The reasoning is almost the same I've tried to explain in [1]. Sorry if it sounds like ancillary changes. But in this way qconfig tool is more effective and helpful. Thanks. Massimo [1] https://lore.kernel.org/all/cac928hyuq6rijik177mtxmt7khu8qbwywrt2h2f6cx8z1r0...@mail.gmail.com/ > > Cheers, > Quentin > > > Signed-off-by: Massimo Pegorer <[email protected]> > > --- > > arch/arm/mach-rockchip/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig > > index 1a2e7847c9e..5ed774159be 100644 > > --- a/arch/arm/mach-rockchip/Kconfig > > +++ b/arch/arm/mach-rockchip/Kconfig > > @@ -836,11 +836,13 @@ config SPL_HAS_BSS_LINKER_SECTION > > default y if ARM64 > > > > config SPL_BSS_START_ADDR > > + depends on SPL_HAS_BSS_LINKER_SECTION > > default 0x63f80000 if SPL_TEXT_BASE = 0x60000000 > > default 0x43f80000 if SPL_TEXT_BASE = 0x40000000 > > default 0x03f80000 if SPL_TEXT_BASE = 0x00000000 > > > > config SPL_BSS_MAX_SIZE > > + depends on SPL_BSS_LIMIT > > default 0x8000 if SPL_BSS_START_ADDR = 0x63f80000 > > default 0x8000 if SPL_BSS_START_ADDR = 0x43f80000 > > default 0x8000 if SPL_BSS_START_ADDR = 0x03f80000 > > >
