f) longer discussion about rocm suffix in binaries, and other naming issues
https://bugs.launchpad.net/ubuntu/+bug/2133814/comments/9 https://bugs.launchpad.net/ubuntu/+bug/2133814/comments/15 I'm also a big fan of being at least consistent. But what I see in the latest revision might have addressed most of that to an acceptable amount. While none of the discussions mentioned it I now see only things under the same structure now. Filtering out "/usr/lib/rocm" leaves only directories and and tries in usr/share/doc or usr/shar7lintian. But filtering just for "/usr/lib/rocm" seems pretty consistent now: It is just /usr/lib/rocm/llvm and in there a full llvm structure. No other *fixes except the basic 20 that is the soname in some libs and the path in ./usr/lib/rocm/llvm/lib/clang/20/ I can't see the old mix that was criticized but that seems fine. Tackling all cases that are left to be outside of ./usr/lib/rocm: --- Those few that are left come down to #1 amd_comgr ./usr/lib/libamd_comgr.so.3 -> libamd_comgr.so.3.0.0 ./usr/lib/libamd_comgr.so -> libamd_comgr.so.3 ./usr/lib/libamd_comgr.so.3.0.0 You mentioned later have been intentional I could not follow why all else is put away, but those have to be here. For consistency - could those live stowed away as well? --- And #2 I see cmake things: /usr/lib/cmake/AMDDeviceLibs/AMDDeviceLibsConfig.cmake /usr/share/lintian/overrides/libclang-cpp-rocm ./usr/lib/cmake/amd_comgr/amd_comgr-config.cmake ./usr/lib/cmake/amd_comgr/amd_comgr-targets.cmake ./usr/lib/cmake/amd_comgr/amd_comgr-targets-relwithdebinfo.cmake To be consistent - Could those live with the many others at /usr/lib/rocm/llvm/lib/cmake without breaking the world? --- And #3 hipcc ./usr/bin/hipcc ./usr/bin/hipconfig I get those, you want them to be in the default path to be available and they do not conflict name-wise This also matches how src:rocm-llvm places hipcc along normal llvm so far. That one is IMHO OK -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2133814 Title: NEW package request: llvm-toolchain-rocm To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2133814/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
