j) d/copyright check

Wow this is complex, I do no envy you creating and updating that, here a
few things I found to look after.

I chased down a double comparison or `lrc` and `licensecheck` and found a bunch 
of falsepositives like doc files having examples with a different text of 
config with examples how to define a header.
But I also found a few which seem real wrong entries, I ask you to fix those as 
reported.

--

  llvm/lib/Support/BLAKE3/blake3.c is CC0-1.0
  llvm/lib/Support/BLAKE3/blake3.c

I do not know why, but it falls out of the rest of the apache2+lvm block
and should therefore be mentioned separately.

./llvm/docs/GoldPlugin.rst explains that the plugin it carries (despite having 
a header of apache2+llvm) uses the GPL-v3 API and so is the resulting binary. I 
thought ./llvm/tools/gold/gold-plugin.cpp
 ... but now. Hmm, for declaring the source licenses I think this is fine. 
Confusing, but no change needed for that.

--

Some entries in the copyright file are for files no more existing, please drop 
those.
If you happen to know what has replaced them you might follow that:

- lldb/tools/debugserver/source/MacOSX/stack_logging.h
- amd/comgr/comgr-backward-compat.cmake
- amd/comgr/tesxt/compile_hip_test.c                   
- amd/comgr/test/compile_hip_test.MITc                 
- amd/comgr/test/source/source1.s 

Such misses usually indicate a change in the sources, and you might also
find files in similar places that you want to add.

--

amd/comgr/tesxt/compile_hip_test.c

You correctly declared this as https://spdx.org/licenses/NCSA.html, but
there is a typo (typo tesxt -> test).

--

137 Files: clang/lib/Headers/cuda_wrappers/* 
138  clang/lib/Headers/avx512vlvp2intersectintrin.h                             
     
139  clang/lib/Headers/avx512vp2intersectintrin.h                               
    

You have a section for ^^ in regard to the copyright.
But by my tools reading this is Expat/MIT and not apache-2 as currently 
declared.

The same applies for debian/patches/0004-rocm-llvm-work-around-new-
assert-in-array.patch BTW adding another such wrapper.

--

compiler-rt/lib/builtins/extendhftf2.c
compiler-rt/lib/builtins/trunctfhf2.c

For whatever reason ^^ is MIT + NCSA

--

GPL-2+ with Autoconf-data exception instead of apache for

llvm/cmake/config.guess

--

Those two seem public-domain

llvm/include/llvm/Support/MD5.h
llvm/lib/Support/MD5.cpp

--

A bunch of others have A|B licenses, but they are covered correctly by
your base apache2+llvm glob.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2133814

Title:
  NEW package request: llvm-toolchain-rocm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2133814/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to