Hi Edwin,
Please see my comments below on your new webrev.
Thanks,
April
components/ksh93/developer-astdev.p5m:
- I'm not sure whether or not you need the trailing ".0" at the end.
Perhaps it's better to be consistent with the other build #s
and leave it off?
25 value=pkg:/developer/[email protected]
components/ksh93/developer-astdev93.p5m:
- This should be an "optional" dependency, instead of "require".
We only want to install the old astdev renamed pkg if astdev is already
installed.
63 depend fmri=pkg:/developer/[email protected] \
64 type=require
components/ksh93/ksh93.p5m:
- Change "require" to "optional."
Extra ".0" at the end of the build # ?
114 depend fmri=pkg:/shell/[email protected] \
115 type=require
components/ksh93/shell-ksh.p5m:
- Extra trailing ".0?"
24 set name=pkg.fmri \
25 value=pkg:/shell/[email protected]
components/ksh93/source-demo-ksh.p5m
- Extra trailing ".0?"
24 set name=pkg.fmri \
25 value=pkg:/source/demo/[email protected]
components/ksh93/source-demo-ksh93.p5m:
- Extra trailing ".0?" Also, change "require" to "optional."
61 depend fmri=pkg:/source/demo/[email protected] \
62 type=require
On 06/14/12 08:52 AM, Edwin Beasant wrote:
I've made the changes suggested by April and Alan and respun the webrev:
Original review request.
----
Can I please have a code review for:
7168548 <http://monaco.us.oracle.com/detail.jsf?cr=7168548> package
shell/ksh version number needs to conform.
Webrev:
http://jurassic.us.oracle.com/~ebeasant/webrevs/7168548/
Workspace:
x86: /net/shelf.uk.oracle.com/vol01/builds/ebeasant/userland/7168548
SPARC: /net/grinah.uk.oracle.com/builds/ebeasant/7168548
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
