LGTM Do we have test cases for this?
http://codereview.chromium.org/119048/diff/1/2 File src/ic.cc (right): http://codereview.chromium.org/119048/diff/1/2#newcode878 Line 878: bool interceptor_found = lookup.IsValid() && lookup.IsCacheable() Could you include a comment? Maybe combine interceptor_found and receiver->...->IsUndefined() to one has_interceptor_setter bool? I guess there is a symmetric case for a property that has an interceptor setter but no getter? http://codereview.chromium.org/119048 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
