BTW, why we don't compile stubs for global object? yours, anton.
On Tue, Jun 2, 2009 at 11:42 PM, <[email protected]> wrote: > > Thanks a lot Mads! > > I've added a test case, but... > > For some reason ScriptUsingAsciiStringResource started to fail. Most > surprisingly it fails even if I add empty test. Does anybody know what > goes on? It was the same story with load interceptor, but it cured > itself somehow. > > > http://codereview.chromium.org/119048/diff/1/2 > File src/ic.cc (right): > > http://codereview.chromium.org/119048/diff/1/2#newcode878 > Line 878: bool interceptor_found = lookup.IsValid() && > lookup.IsCacheable() > On 2009/06/02 17:22:44, Mads Ager wrote: >> Could you include a comment? > >> Maybe combine interceptor_found and receiver->...->IsUndefined() to > one >> has_interceptor_setter bool? > >> I guess there is a symmetric case for a property that has an > interceptor setter >> but no getter? > > > What kind of comment? > > I reworked this piece notably and noted that if receiver is global proxy > we do a lookup just to be immediately discarded. And surprise surprise > for older dom_bench 90.5% (sic!) try to do that. Alas, peacekeeper > doesn't do anything of that kind :( > > And yes, there is a symmetric case. However, at least for DOM (but I'd > guess overall), it's more typical to have only a getter, not vice versa. > Maybe file an issue? > > http://codereview.chromium.org/119048 > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
