LGTM On 2009/06/02 19:42:29, antonm wrote: > Thanks a lot Mads!
> I've added a test case, but... > For some reason ScriptUsingAsciiStringResource started to fail. Most > surprisingly it fails even if I add empty test. Does anybody know what goes on? > It was the same story with load interceptor, but it cured itself somehow. Odd, I have no idea. How does it fail? > http://codereview.chromium.org/119048/diff/1/2 > File src/ic.cc (right): > http://codereview.chromium.org/119048/diff/1/2#newcode878 > Line 878: bool interceptor_found = lookup.IsValid() && lookup.IsCacheable() > On 2009/06/02 17:22:44, Mads Ager wrote: > > Could you include a comment? > > > > Maybe combine interceptor_found and receiver->...->IsUndefined() to one > > has_interceptor_setter bool? > > > > I guess there is a symmetric case for a property that has an interceptor > setter > > but no getter? > > > What kind of comment? With the new naming I think it is fine without a comment. Thanks. The reason for not generating store IC stubs for JSGlobalProxy is that the stubs do not correctly handle the JSGlobalProxy object (it would store directly in the proxy object which should never be done). We should fix that. http://codereview.chromium.org/119048 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
