lgtm
normally when we do this, we convert all the cctest files to use the new
api,
and we introduce one test for the old behaviour (as you've done).
Please do that either in this CL or an immediate follow up.
https://codereview.chromium.org/467013003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/467013003/diff/1/include/v8.h#newcode3730
include/v8.h:3730: void SetGenericNamedPropertyHandler(
should be SetNamedPropertyHandler. easier to get rid of the old version
that way.
https://codereview.chromium.org/467013003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/467013003/diff/1/src/objects.cc#newcode2914
src/objects.cc:2914: (!name->IsString() &&
!interceptor->can_intercept_symbols())) {
everywhere else you do
name->IsSymbol() && !interceptor->can_intercept_symbols()
can you please do that here for consistency
https://codereview.chromium.org/467013003/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/467013003/diff/1/src/objects.h#newcode10850
src/objects.h:10850: inline void set_flags(int flags);
can you add a TODO here to remove the flags field when the Generic
interceptors are renamed?
https://codereview.chromium.org/467013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
