lgtm
https://codereview.chromium.org/467013003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/467013003/diff/1/include/v8.h#newcode3730
include/v8.h:3730: void SetGenericNamedPropertyHandler(
On 2014/08/13 10:45:39, wingo wrote:
On 2014/08/13 08:25:39, dcarney (ooto) wrote:
> should be SetNamedPropertyHandler. easier to get rid of the old
version that
> way.
Alack, I just did this, but:
../test/cctest/test-api.cc: In function 'void
TestGetOwnPropertyNamesWithInterceptor()':
../test/cctest/test-api.cc:9672:64: error: call of overloaded
'SetNamedPropertyHandler(NULL, NULL, NULL, NULL, void (&)(const
v8::PropertyCallbackInfo<v8::Array>&))' is ambiguous
I am thinking that breaking this code is acceptable, though, as
Chromium is
unlikely to have code of this form. WDYT?
i didn't even know this was supported. since it's a primitive form of
interceptor, anything using it should use an interceptor instead . If
chrome doesn't compile with this, which is super unlikely, we can fix
before landing by casting the first argument.
https://codereview.chromium.org/467013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
