https://codereview.chromium.org/467013003/diff/40001/src/objects.cc
File src/objects.cc (left):
https://codereview.chromium.org/467013003/diff/40001/src/objects.cc#oldcode13612
src/objects.cc:13612: // TODO(rossberg): support symbols in API, and
filter here if needed.
On 2014/08/19 11:36:37, rossberg wrote:
Note that simply relaxing this function to also return symbol names
will break
(indirect) use sites. In particular, it is used by
JSReceiver::GetKeys, which in
turn is invoked in various places, some of which are not expecting
symbols
(e.g., JsonStringifier).
I'm afraid you need to carefully check and adapt all transitive
dependencies
(and include respective tests).
Good catch. I've taken a look at other callers and it's only this one
that needs filtering. OTOH is filtering the right thing? Would it be
better to add an enumerator callback that returns symbols?
https://codereview.chromium.org/467013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
